DC++ has crashed (CVS version)

darwusch · Post by **darwusch** » 2004-04-12 05:15

Here's my crash info:

Unhandled Exception
Code: c0000005
Version: 0.401
Os: WinXP ProSP1
Call stack info:
c:\download\new\dc++ includes\stl46\stl\_string.h(627) : _STL::basic_string<char=0x003BAC78,_STL::char_traits<char>=0x003BAC78,_STL::allocator<char> >::_M_assign_dispatch<char *>
c:\download\new\dc++ includes\stl46\stl\_string.h(310) : _STL::basic_string<char=0x004DE4A8,_STL::char_traits<char>=0x01F12250,_STL::allocator<char> >::operator=
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\client\clientmanager.h(121) : ClientManager::putUserOffline
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\client\nmdchub.cpp(88) : NmdcHub::clearUsers
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\client\nmdchub.cpp(51) : NmdcHub::~NmdcHub
DCPlusPlus!0x0046B059 : NmdcHub::`scalar deleting destructor'
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\client\clientmanager.cpp(71) : ClientManager::putClient
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\windows\hubframe.h(272) : HubFrame::~HubFrame
DCPlusPlus!0x00415A0C : HubFrame::`scalar deleting destructor'
c:\download\new\0.1737-k-bin\cvs_4_4\dcplusplus\windows\hubframe.h(94) : HubFrame::OnFinalMessage
c:\program files\microsoft visual studio .net 2003\vc7\atlmfc\include\atlwin.h(3041) : ATL::CWindowImplBaseT<WTL::CMDIWindow=0x00000000,ATL::CWinTraits<1456406528=0x00000010,64> >::WindowProc
USER32!0x77D43A50 : ?
USER32!0x77D43B1F : ?
USER32!0x77D43D79 : GetMessageW
USER32!0x77D44374 : DispatchMessageA

What I did was connecting to a hub.
After I hit "connect" it crashed.

[Edit by Guitarm: I took away reference to 0.402]

Guitarm · Post by **Guitarm** » 2004-04-12 05:31

Looks the same as mine, I suppose this one is due to the splitting of code in nmdchub and adchub. Looks like a pointer error. I suppose Arnie's looking into it as his ADC integration's progressing.

darwusch · Post by **darwusch** » 2004-04-12 05:47

Did you already try with the newest STL port, like arne is doing in his latest cvs ?

btw, nice to see you finally found a nice picture to go with your name

Guitarm · Post by **Guitarm** » 2004-04-12 05:54

Well, actually I changed the code to make it work with STLPort 4.6.0, So, sure, that can be one of the reasons..., But isn't it so that Arnie has tweaked the standard STLPort?, I haven't seen a downloadable (and tweaked) 4.6.1, have you?.

BTW, Yes, I thought it was time to change my avatar. Playing guitar is the love of my life so....

darwusch · Post by **darwusch** » 2004-04-12 06:36

Yes, the STL is a bit different, but I changed the 4.6.1 version myself.
It's just a couple of minor changes, you can find them if you compare the original 4.6.0 with the changed one.

Now I'm testing with this new stl version.

Guitarm · Post by **Guitarm** » 2004-04-12 06:40

Oh...You mean there's just additions to the 4.6.1?, So I just d/l the 4.6.1 and add from 4.6.0 then.

darwusch · Post by **darwusch** » 2004-04-12 06:46

The changes are for instance a removal of a commented line in the standard edition.
And some lines have a changed position (line) in the file.

Guitarm · Post by **Guitarm** » 2004-04-12 06:54

Oh, ok, thanks!, I'll try it out

darwusch · Post by **darwusch** » 2004-04-12 09:38

It seems I also get it when I remove/add a user for a download:

Unhandled Exception
Code: c0000005
Version: 0.401
Os: WinXP ProSP1
Call stack info:
ntdll!0x77F585C0 : RtlAllocateHeap
f:\vs70builds\3077\vc\crtbld\crt\src\malloc.c(212) : _heap_alloc
f:\vs70builds\3077\vc\crtbld\crt\src\malloc.c(113) : _nh_malloc
f:\vs70builds\3077\vc\crtbld\crt\src\malloc.c(54) : malloc
f:\vs70builds\3077\vc\crtbld\crt\src\newop.cpp(12) : operator new
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\windows\transferview.cpp(395) : TransferView::onConnectionAdded
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\windows\transferview.cpp(615) : TransferView::onAction
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\speaker.h(46) : Speaker<ConnectionManagerListener>::fire<ConnectionQueueItem *>
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\connectionmanager.cpp(80) : ConnectionManager::getDownloadConnection
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\queuemanager.cpp(789) : QueueManager::putDownload
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\downloadmanager.cpp(610) : DownloadManager::removeDownload
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\downloadmanager.cpp(551) : DownloadManager::onMaxedOut
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\downloadmanager.cpp(652) : DownloadManager::onAction
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\speaker.h(46) : Speaker<UserConnectionListener>::fire<UserConnection *>
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\userconnection.cpp(82) : UserConnection::onLine
c:\download\new\0.1737-k-bin\cvs_4_4_stl\dcplusplus\client\userconnection.cpp(176) : UserConnection::onAction

Guitarm · Post by **Guitarm** » 2004-04-12 09:52

Hmm.....weird, this looks like it's a bit deeper, a memory allocation on the heap. it's a call to "new" that goes heywire...., Access violation. I don't get this..., I have w2k sp4 if that has anything to do with it.

Gasman1015 · Post by **Gasman1015** » 2004-04-12 12:14

My apologies for butting in on your thread fellas, but don't you think this conversation would be better in Programmers Help (Hint to Guitarm).
Also your reference to 0.402 is a tad off line. I presume you are compiling Cvs version.
Might just confuse matters for other users wondering where is this latest version.

btw nice to see you trying to iron out the bugs.

darwusch · Post by **darwusch** » 2004-04-12 12:21

You're right about the subject of this thread.
Just edited subject to CVS version.

ivulfusbar · Post by **ivulfusbar** » 2004-04-12 12:30

Its also somewhat useless to report CVS-errors without mentioning which version you use on the specific files et.c.

Post by **GargoyleMT** » 2004-04-12 13:02

Which I suspect is why arne also doesn't want bug reports in the bug tracker. Much too difficult to figure out what version you're running, etc.

Guitarm · Post by **Guitarm** » 2004-04-12 13:21

Off course, you all have a point, Nice of you to join us!, We are just speculating/discussing a bit over an early version of a popular program here. Gasman: You're right, I forgot my role as a moderator, I got too caught up in the discussion to see the obvious

(I'll move it). Garg/fusbar: quite right, Garg and me had this discussion where I came to understand that Arnie does not want reporting of bugs in CVS version added to the bugtracker (I assume all of us can discuss the CVS version somewhere?, It being released and able to compile and test). So, to sum this up I'll move this to Programmers help and you are all very welcome to further discuss the subject

Regards

Guitarm

Post by **GargoyleMT** » 2004-04-12 13:34

It's a good solution to me.

Having the code in CVS does no good if it's not getting testing as well, so of course bug reports have a huge amount of worth.