BufferedSocket memory leak

Problems compiling? Don't understand the source code? Don't know how to code your feature? Post here.

Moderator: Moderators

Locked
Big Muscle
Posts: 72
Joined: 2004-01-23 14:45

BufferedSocket memory leak

Post by Big Muscle » 2006-06-14 04:48

Hi, there's memory leak in BufferedSocket in DC++ 0.69x...

If some function in BufferedSocket::checkEvents() throws exception, it will be caught in BufferedSocket::run(). But "p.second" in checkEvents() won't be deleted.

Carraya
Posts: 112
Joined: 2004-09-21 11:43

Post by Carraya » 2006-06-14 07:13

I'm sure arne would implement a diff you would send him. :)
<random funny comment>

Big Muscle
Posts: 72
Joined: 2004-01-23 14:45

Post by Big Muscle » 2006-06-15 14:10

i don't know exactly how to fix it... I made solution by adding try..catch in while loop in checkEvents() and "delete p.second" in catch block, but i'm not sure about this solution :arrow: it removes memory leak but i don't know about negative influence.

Locked