UploadManagerListener::Failed

stevensheehy · Post by **stevensheehy** » 2006-03-22 21:41

As I was working on LinuxDC++, I noticed we had a listener for DownloadManagerListener::Failed, but not UploadManagerListener::Failed. Thinking we forgot to include it, I looked at windows DC++ in TransferView.h/cpp and I didn't see one either. It shows one is fired in UploadManager.cpp so I'm wondering if this is a bug or if it is not needed so that I can safely omit it?

Thanks,
Steven

Post by **GargoyleMT** » 2006-03-26 17:04

You're right that there is no listener. Unless you have a reason to add one, stick as close to DC++'s code base as possible. Trying to optimize it out may end up being more trouble for you in the end.

stevensheehy · Post by **stevensheehy** » 2006-03-27 01:57

Okay. I figured your transferview code was correct but just wanted to make sure. Just seems kind of weird design to have a failed for download but not upload so I thought I'd bring it up. As long as it works, I guess. :)

Thanks