Deadlock when close hub frame

Problems compiling? Don't understand the source code? Don't know how to code your feature? Post here.

Moderator: Moderators

Locked
3x3x3
Posts: 2
Joined: 2004-07-15 21:31

Deadlock when close hub frame

Post by 3x3x3 » 2004-07-27 21:10

Hello there.

I runned the debug version in VisualStudio 2003 debugger.
I connected to a hub, then closed the HubFrame, DC++ deadlock.
I am using 0.403 without any change, compiled with WTL7.1 + stlport4.6.2 got from here:

http://sourceforge.net/project/showfile ... e_id=32827

After pause the program and check stacktrace, I found the WTL::CButton.GetCheck() didn't return.
Please see the screenshot for more information.

http://www.aloofhosting.com/3x3x3/

Any help is appreciated.
Last edited by 3x3x3 on 2004-07-28 05:14, edited 1 time in total.

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-28 04:01

Image not working.
The world is coming to an end. Please log off.

DC++ Guide | Words

Guitarm
Forum Moderator
Posts: 385
Joined: 2004-01-18 15:38

Post by Guitarm » 2004-07-28 06:25

Strange, I've compiled and run 0.403 in both debug and release modes and I haven't seen this error. Are you sure you have included stlport and wtl the right way ?

Regards
"Nothing really happens fast. Everything happens at such a rate that by the time it happens, it all seems normal."

3x3x3
Posts: 2
Joined: 2004-07-15 21:31

Post by 3x3x3 » 2004-07-28 09:26

thanks for reply.

I tested this with DC++ release version, and got the same result.
How to test:
1) connect to a laggy hub with 3000+ users
2) once you receive user list, close the hub window at once.

retry if no freeze.

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-07-28 11:12

Closing a hub window while the user list is being loaded is a known issue. Of course you see it most on large hubs. If you want to take a look at it and work up a fix, that would be appreciated.


I've seen deadlocks, but only in debug mode on cvs derived clients - BCDC. In my case, disabling the hub flashing (seems to have) fixed it.

JohnSmith
Posts: 3
Joined: 2004-07-24 15:26
Location: Belgrade, Serbia & Montenegro

Re: Deadlock when close hub frame

Post by JohnSmith » 2004-07-29 08:22

3x3x3 wrote:Hello there.
Please see the screenshot for more information.
http://www.aloofhosting.com/3x3x3/

OT: What is the font you used in Editor?

Big Muscle
Posts: 72
Joined: 2004-01-23 14:45

Post by Big Muscle » 2004-07-31 15:09

Deadlock is caused by function HubFrame::getUserInfo();

Code: Select all

   bool getUserInfo() { return ctrlShowUsers.GetCheck() == BST_CHECKED; }


I've just replaced its content with

Code: Select all

   bool getUserInfo() { return ShowUserList; }


and no deadlocks now :))

Locked