Version tag for XML preference file

[Qbert]

Do you feel that some setting tags should be more categorized under a specific (or range) of DC++ versions? I'm not confident in an answer yet.

For example,

Code: Select all

<MainFrameWidths type="string">#,#,#,#,#,#,#,#</MainFrameWidths>

contradicts in some versions, such as 0.305 and 0.307. (I have not ran 0.306) In transitioning up to a higher version (or the rare chance down,) I think this setting should be the default for that version instead of applying a different version's settings.

[Twink]

Code: Select all

<MainFrameWidths type="string">#,#,#,#,#,#,#,#</MainFrameWidths>

really should be defined with unique id's rather then relying on indexes within an array but that would take up more space be more complex to code. What I did do for my mod (PhantomDC) is that when reading the frame widths in, if the number of settings in the file isn't equal to the number of columns then just use the default ones instead, not the best solution but it seemed to work nicely for something or rather.

[TheParanoidOne]

My thinking is that both DCPlusPlus.xml and Queue.xml should have some version information in the root element.

[FarCry]

The DCPlusPlus.xml has

Code: Select all

<ConfigVersion type="string">0.306</ConfigVersion>

which is already used for legacy settings support.

A more structured settings file is desirable, but would need more complete XML support than the current (well, V0.306) SimpleXML parser implementation provides.