DC++ 0.231 crash when opening Finished Dl frame

Technical discussion about the NMDC and <a href="http://dcpp.net/ADC.html">ADC</A> protocol. The NMDC protocol is documented in the <a href="http://dcpp.net/wiki/">Wiki</a>, so feel free to refer to it.

Moderator: Moderators

Locked
Who
Posts: 10
Joined: 2003-01-28 10:47
Contact:

DC++ 0.231 crash when opening Finished Dl frame

Post by Who » 2003-02-11 04:34

at FinishedFrame.h, addEntry function:

the call

setDirty();

at the end of the function makes DC++ crash, because MDITabChildWindowImpl<FinishedFrame> onCreate has not been called, and Tab has not been added yet.

BTW dunno if this is the proper place to report this, if you know a more suitable place, tell me please.

Greetings
Who

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

bug reports

Post by GargoyleMT » 2003-02-12 12:02

There's a bit of a thread (if you can call it that) at the sourceforge bug tracker for this already, it is number 680443.

The problem is the FinishedFrame's onCreate calls updateList, which sets it dirty (if the list is non-empty), which uses tab information that's not set up until the onCreate method in the base class is called. A previous poster in that thread came up with one solution, and I pasted in a diff of it.

It seems an inelegant solution, but...

Who
Posts: 10
Joined: 2003-01-28 10:47
Contact:

about reporting

Post by Who » 2003-02-13 03:50

I guessed so, all I wanted to know is where I can follow those threads. Now you said sf bugtracker, I'll follow. Thanks

Locked