Fix for bug in current CVS revision (0.241)

Technical discussion about the NMDC and <a href="http://dcpp.net/ADC.html">ADC</A> protocol. The NMDC protocol is documented in the <a href="http://dcpp.net/wiki/">Wiki</a>, so feel free to refer to it.

Moderator: Moderators

Locked
ugumba
Posts: 5
Joined: 2003-03-06 17:33

Fix for bug in current CVS revision (0.241)

Post by ugumba » 2003-04-16 17:24

client\util.h contains the line

if((c == lower[(u_int8_t)*a]) && strnicmp(a+pos+1, b+1, blen-1) == 0)

which should be

if((c == lower[(u_int8_t)*(a+pos)]) && strnicmp(a+pos+1, b+1, blen-1) == 0)

The bug manifested itself most notably by rejecting $SRs where the first letter in the result was not the same letter as the initial letter of each search word. Subsequently, all multiword searches failed, unless all words started with the same letter :-)

arnetheduck
The Creator Himself
Posts: 296
Joined: 2003-01-02 17:15

Post by arnetheduck » 2003-04-17 08:42

Good point...=) I should profile that one as well, in theory it should be a tiny little bit faster, but you never know...

Locked