report dupes that has been removed
Moderator: Moderators
report dupes that has been removed
Many users have gotten their shares shrinked in DC++ 0.401.
I guess this is cause of the improved dupe removing function, which is good.
However, this causes some problems to the users, that (apperently) were sharing dupes without beeing aware of it.
Some kind of reporting mechanism for the dupe removing would be most welcome. A "dupes.txt" in the DC++ directory would do just fine.
I guess this is cause of the improved dupe removing function, which is good.
However, this causes some problems to the users, that (apperently) were sharing dupes without beeing aware of it.
Some kind of reporting mechanism for the dupe removing would be most welcome. A "dupes.txt" in the DC++ directory would do just fine.
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
Re: report dupes that has been removed
Are dupes really removed, or just not counted in the share size?
removed if you don't check the "include dupes" option.
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
so there is a system message for each file that is removed then?
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
Indeed.. and it gets quite big if you have many dupe files (they're checked every time you /refresh after all, and with automatic refresh on.. I never realised i had so many dupes.. but it's a great inspiration to sort your share properly.. i only wish both locations of the file was written to the logfile.. *hint hint*)
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
hm, I think that the dupe feature is broken... it seems that if the dupe files have the same name... they are not recognized as dupes...
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
yes, I know it works by comparing hashes.. but the files is already hashed.. I had a folder shared... with hashes.. then I copyed that folder and shared that too.. since it's the same files.. DC++ does no new hashing.. and no dupe removing either... cause it has no hashes to compare I guess.. ?
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
Indeed.cyberal wrote:cause it has no hashes to compare I guess.. ?
Here's the teeny tiny test I did:
Three files shared:
C:\test\test.txt wrote:This is a test
C:\test\Folder\test.txt wrote:This is b test
On startup:C:\test\Copy of test.txt wrote:This is a test
No dupes were removed despite two files with the same size and name, due to no available hashing information.system.log wrote:2004-03-29 15:55:44: File list refresh initiated
2004-03-29 15:55:44: Finished hashing C:\test\Copy of test.txt
2004-03-29 15:55:44: Finished hashing C:\test\Folder\test.txt
2004-03-29 15:55:44: Finished hashing C:\test\test.txt
2004-03-29 15:55:44: File list refresh finished
On /refresh:
One of the files is seen as a duplicate because of the available file hashing information. Unfortunately, due to my lousy naming scheme, it is unclear what the names refer to. :sigh:system.log wrote:2004-03-29 15:55:57: File list refresh initiated
2004-03-29 15:55:57: Duplicate file will not be shared: test.txt (Size: 14 B) (Directory: "test")
2004-03-29 15:55:57: File list refresh finished
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
I assume you mean this thread?TheParanoidOne wrote:The "include duplicate files" options has been explained to you before. Why do you keep asking about it?Wisp wrote:what's the point of removing duplicate's? Why not exclude them from the share size ?
There's not a clear answer there, or maybe i'm overlooking something
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
and that was not the point... DC++ does not see them as dupes at all!Wisp wrote:what's the point of removing duplicate's? Why not exclude them from the share size ?
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
Code: Select all
2004-03-29 19:04:43: Finished hashing D:\Download\test1\ORiON-DiABLO_keygen_Nero.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\ORiON-keygen-GameSpy.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\ORiON-keygen-Nero-again.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\ORiON-keygen-Nero.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\ORiON-keygen-Tapptoons.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-keygen-CloneCD.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-keygen-FireBurner.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-keygen-Norton2004.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-keygen-TVtool.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-keygen-WinRar.exe
2004-03-29 19:04:43: Finished hashing D:\Download\test1\TMG-NFO.exe
2004-03-29 19:04:45: File list refresh initiated
2004-03-29 19:04:45: File list refresh finished
2004-03-29 19:05:31: Finished hashing D:\Download\test2\ORiON-DiABLO_keygen_Nero.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\ORiON-keygen-GameSpy.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\ORiON-keygen-Nero-again.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\ORiON-keygen-Nero.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\ORiON-keygen-Tapptoons.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-keygen-CloneCD.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-keygen-FireBurner.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-keygen-Norton2004.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-keygen-TVtool.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-keygen-WinRar.exe
2004-03-29 19:05:31: Finished hashing D:\Download\test2\TMG-NFO.exe
2004-03-29 19:05:32: File list refresh initiated
2004-03-29 19:05:32: File list refresh finished
2004-03-29 19:06:02: File list refresh initiated
2004-03-29 19:06:02: File list refresh finished
B. Added test2 (which is an exact copy of test1) and let that hash
C. Did another manual refresh
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- DC++ Contributor
- Posts: 3212
- Joined: 2003-01-07 21:46
- Location: .pa.us
When it was doing duplicate checks by filename and size, this wasn't easily possible without reworking the code. =) It's probably a different story now, though.Todi wrote:I only wish both locations of the file was written to the logfile.
FYI, it will always hash the file again, even if the file was moved from elsewhere in your share. DC++ cannot know that the file hasn't changed without hashing.cyberal wrote:since it's the same files.. DC++ does no new hashing
I took an already hashed file, copied it into a New Folder (in my share) (so it has the same name), /refreshed, let it finish hashing, then did another /refresh and got the duplicate-by-hash warning.cyberal wrote:A. I added test1 and let it hash the files
B. Added test2 (which is an exact copy of test1) and let that hash
C. Did another manual refresh
do you still get the same behavior?
if you open your file list, are the hashes the same?
*cough*
this bug still exists..
when a file has the same hash AND filename.. it is not "dupelized"
this bug still exists..
when a file has the same hash AND filename.. it is not "dupelized"
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- Forum Moderator
- Posts: 1420
- Joined: 2003-04-22 14:37
Indeed.
The use of the word "junction" made me think that you were creating NTFS hard links for directories, but reading that line again, I'm not sure sure. Can you explain what you meant?CyberAL wrote:[2004-07-25 16:41] <CyberAL> I share the same albums, 4 times, cause of the junction link mp3-sorting... my reported total share size should be 1/4 of what the filelist says.. but it isn't
-
- DC++ Contributor
- Posts: 3212
- Joined: 2003-01-07 21:46
- Location: .pa.us
Re-testing with the CVS code I have handy seems to confirm that filenames with the same name and hash are removed from the share.
You're using DC++ 0.403, not fulDC? Trem purposefully removed the dupe check in that mod.
I was going to download your whole share to see if the same happened on my end, but I figured that might be a bit wasteful, even if you do have free slots.
You're using DC++ 0.403, not fulDC? Trem purposefully removed the dupe check in that mod.
I was going to download your whole share to see if the same happened on my end, but I figured that might be a bit wasteful, even if you do have free slots.
TheParanoidOne> you are correct, it's NTFS junction links
GargoyleMT> I use fulDC 6.49, you say Trem removed the dupe check? You know why?
GargoyleMT> I use fulDC 6.49, you say Trem removed the dupe check? You know why?
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
-
- DC++ Contributor
- Posts: 3212
- Joined: 2003-01-07 21:46
- Location: .pa.us
k, thanks for the help
http://whyrar.omfg.se - Guide to RAR and DC behaviour!
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet
http://bodstrom.omfg.se - Bodströmsamhället, Länksamling om hoten mot vår personliga integritet