Automatically dropping slow users

Archived discussion about features (predating the use of Bugzilla as a bug and feature tracker)

Moderator: Moderators

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Automatically dropping slow users

Post by xhost+ » 2004-02-24 15:59

Over the last past months I have been testing a feature I added to DC++ : Any item in the queue can be tagged so that if the download speed of the item you are downloading falls below a settable threshold for a settable period of time, the user you are downloading from is automatically removed from the queue.
Both download speed threshold and confirmation period are settable within the advanced settings page (in kb/s and minutes).
For the moment this tag is not saved with the queue (so you have to reselect the items you want to speed-control one by one every time you restart DC++).

If anyone is interested in this feature, please let me know.

xhost+

Todi
Forum Moderator
Posts: 699
Joined: 2003-03-04 12:16
Contact:

Post by Todi » 2004-02-24 16:11

Sounds like an interested (and fairly well requested) feature. Would probably mostly be useful for high-bandwidth users, but then again there are quite a lot of those =) Good work.

[B]bongretarded
Posts: 47
Joined: 2004-01-27 19:16
Location: Auckland New Zealand
Contact:

Post by [B]bongretarded » 2004-02-24 16:34

Hasn't this feature been put into other clients? Like bcdc and pdc++???
A friend indeed is a friend in need a friend with weed is better

Twink
Posts: 436
Joined: 2003-03-31 23:31
Location: New Zealand

Post by Twink » 2004-02-25 01:06

[B]bongretarded wrote:Hasn't this feature been put into other clients? Like bcdc and pdc++???


not bcdc that I know of, iDC and PDC have it thou, but not everyone wants to use mods, infact it is better alot of the time to use the vanilla dc++. This feature has been requested a number of times and mostly the reply is along the lines of using the max speed for starting new downloads and just setting your download slots alittl ehigher then you normally would

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Post by xhost+ » 2004-02-25 13:34

the reply is along the lines of using the max speed for starting new downloads and just setting your download slots alittl ehigher then you normally would


I may be wrong but I don't think that has anything to do with what I did.
The trouble is when you go to bed and DC tells you that there is 6 hours of download remaining and during the night the user you're downloading from log off, the automatic alternate source locator locates an alternate source (hence the name) but unfortunately that source is so slow that you end up the next morning with DC telling you that your download has still 80% remaining and should be finished within the next 37 hours...
What I did is that if a source is detected below say 20 kB/s for more than say 2 minutes, then the user (source) is automatically removed from queue and another one is tried.
With this system, all selected downloads finish in a blink of a moon's eye.

xhost+

Twink
Posts: 436
Joined: 2003-03-31 23:31
Location: New Zealand

Post by Twink » 2004-02-25 14:43

yeah it wasn't the most brilliant idea I must admit (the one i said) but in theory you could have it setup to start a second download when the speed drops or something, but it wouldn't fix the problem of one download not finishing due to crap sources.

rumpleforeskin
Posts: 2
Joined: 2003-02-04 16:50

Post by rumpleforeskin » 2004-02-26 06:52

The only problem i see with this is, what if all the alternate sources are too slow for you. Then you would have no download instead of a slow one.

Quidam
Posts: 4
Joined: 2004-02-26 19:55

comparing alt sources

Post by Quidam » 2004-02-26 19:55

Sounds great to me!

Re: the no sources vs. slow sources, perhaps DC++ could note the rates of the sources (from getting the lists) and simply use the one with the highest average rate.

bajsakissa
Posts: 1
Joined: 2004-02-29 12:34

IM INTERRESTED

Post by bajsakissa » 2004-02-29 12:41

Yes yes yes. Pleeeeaaaase insert this function. I really hate waking up to find my download is down to 20B. Let the user set his own lowest preference. Guess mine would be 15kB/s or something.

Wisp
Posts: 218
Joined: 2003-04-01 10:58

Re: IM INTERRESTED

Post by Wisp » 2004-02-29 15:55

Seems a good feature, there are only a few problems

but if there is only 1 source? better a slow user than nothing

OrangeSlice
Posts: 12
Joined: 2003-12-09 19:53

Re: IM INTERRESTED

Post by OrangeSlice » 2004-02-29 22:45

Wisp wrote:Seems a good feature, there are only a few problems

but if there is only 1 source? better a slow user than nothing


have a user defined variable to set the # of sources a file must have before dc++ starts dropping slow users, simple


and i agree, this would be an excellent feature
Last edited by OrangeSlice on 2004-03-02 01:29, edited 1 time in total.

OrangeSlice
Posts: 12
Joined: 2003-12-09 19:53

Post by OrangeSlice » 2004-02-29 22:46

i meant.. # of sources a file must have


why cant we edits posts...or can we and im missing something, lol

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-03-01 05:11

Posts can only be edited in the Help/Support and Programmers Help sections.
The world is coming to an end. Please log off.

DC++ Guide | Words

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-01 23:13

TheParanoidOne wrote:Posts can only be edited in the Help/Support and Programmers Help sections.


Fixed, registered users should be able to edit their own posts here now. I also set it so that you have to be a moderator to create a poll. :twisted:

Simon F-L
Posts: 4
Joined: 2003-12-15 14:23

Post by Simon F-L » 2004-03-02 16:58

It sounds great with a feature like that. I would really like to have it.

xhost+, have you changed your client and added the feature? If you have can you plz let me download your client or help me add the feature.

Is it ok for anyone to change there own client?

Xan1977
Forum Moderator
Posts: 627
Joined: 2003-06-05 20:15

Post by Xan1977 » 2004-03-02 17:02

GargoyleMT wrote:Fixed, registered users should be able to edit their own posts here now. I also set it so that you have to be a moderator to create a poll.

Good stuff.

Simon F-L wrote:Is it ok for anyone to change there own client?

Yes, but if you release your new client as a binary, you have to make the modified source code easily available.

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Post by xhost+ » 2004-03-05 13:08

OK. Seems that feature's got several votes.
I'll setup a website to download both binary and source code (GNU oblige).

xhost+

Qbert
Posts: 73
Joined: 2003-06-07 03:12

Post by Qbert » 2004-03-05 14:27

It has several votes because it’s been requested before multiple times. And there already are mods with this type of feature built in. Because of that, having a new mod with only this feature seems useless.

I would suggest that you simply submit a patch instead of branching off.
My Visual Studio .NET 2003 is licensed under my name, and the same for my operating system... What about you?
I surf on an OC3 without limitations, two to be exact, and I'm not joking.

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Post by xhost+ » 2004-03-08 13:20

I would suggest that you simply submit a patch instead of branching off.


I have no problem with that. How can I do it ? I browsed the Feature Tracking on SourceForge but couldn't find any way to submit an evolution?
So where to look at ?

xhost+

Todi
Forum Moderator
Posts: 699
Joined: 2003-03-04 12:16
Contact:

Post by Todi » 2004-03-08 13:22

Compile.txt wrote:Submitting patches

If you think you've done something that more people could use, you can always submit a patch for inclusion in the
original distribution. I will then consider whether I like the patch or not based on things that might seem to be
completely random, which just might be the case. Popular reasons for rejecting a patch include, but are not limited to,
ugly code, abusable features, feature that I don't like that bloat the applications and incompatibility with other
modifications I've already done.
To increase the chances of your patch being accepted, mail them to me ([email protected]) as diffs against the latest
code you can find (for the moment, it should be the cvs repository on sourceforge, but sometimes I forget to
update it, so check the source code distribution of the latest release as well...). You can find a lot of
information about diff and patch by googling for it. I like unified format (diff -uNr).
By submitting a patch, you agree to that I get copyright of it. This to avoid stupid situations later on where
the copyright is split out over a million people, each of which could stop further distribution of DC++. If you don't
like this, start your own distribtution, if you're lucky it might become more popular than the original =).

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-11 20:34

xhost+ wrote:I have no problem with that. How can I do it ? I browsed the Feature Tracking on SourceForge but couldn't find any way to submit an evolution?


Email to arne, per the compile.txt directions above, is the surest way to do it. You can attach files to a feature request (in your case, this one) only if you're either a tracker admin or the request submitter.

V1ad1m1r
Posts: 1
Joined: 2004-02-12 10:05

Post by V1ad1m1r » 2004-03-12 11:11

Keep us informed on this one, i have so been looking for just this thing

Simon F-L
Posts: 4
Joined: 2003-12-15 14:23

Post by Simon F-L » 2004-03-31 15:51

Will we ever see this feature. I'm starting to doubt it. :(

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

That's done

Post by xhost+ » 2004-04-03 16:36

Hello all,

The patch has been submitted today.
I had to rework it a little bit to make it compatible with 0.401 (it was 0.305 based).
Hope it'll be included.

xhost+

Tame
Posts: 8
Joined: 2004-04-02 07:38

Post by Tame » 2004-04-03 20:15

have you heard anything back yet? Because i really want this feature i was winding up to having a look at the code my self, but it would have involed learning a new language which really i could not be arsed but i was beginning think it would be worth the effort.

dusdus
Posts: 1
Joined: 2004-01-10 09:35

yes!

Post by dusdus » 2004-04-09 19:08

great idea!
how can I get this feature in my dc++?
(where is it?!)

Timzone8
Posts: 28
Joined: 2004-04-10 09:33
Location: Australia
Contact:

Post by Timzone8 » 2004-04-11 00:16

Sounds like a good idea. You'd have a bit of trouble getting it to accurately drop the source though, especially if the source decides to load a web page or something and the DL speed goes down for a second. Best way is just to monitor it manually. =P

IntraDream
Posts: 32
Joined: 2003-12-12 14:28
Location: FL,USA
Contact:

Post by IntraDream » 2004-04-11 00:51

should be setup on a average system or a counting system.. ie if the 10 second avg is less than the minimum selected speed.. or if the minimun is under the min for 10 seconds streight.. ie 1K/s Min.

5K,3K,0K,0K(8 more = Drop),3K(Reset counter)
or just an timespan average.

If that makes any sence at all to anyone.

Tim-

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Rejected!

Post by xhost+ » 2004-04-13 16:56

should be setup on a average system or a counting system.. ie if the 10 second avg is less than the minimum selected speed.. or if the minimun is under the min for 10 seconds streight.. ie 1K/s Min


Guys... Read the first message... It works on a confirmation window basis whose size you can set.
Anyway I got the answer from Arne and it seems my code infringed several coding rules which were not known to me and thus is rejected.
Since it would take too much time to have it straight back the way Arne would like it, plus the fact that I do it for fun, my needs and not pride of seing my name appended to the credit list (although that would be nice :wink:), I'm afraid you will have to wait 'till someone else does it...

In the meantime, you can try out my mod at http://jdcpp.free.fr.

Its based on 0.401 so it comes with the CPU-and-HD-eating, to-my-point-of-view-totally-useless, hashing capability which I'm very afraid will transform DC into a lame kazaa clone once the multi-source feature is implemented (once you've got hash, guess what'll come next). Well, I'll argue on that somewhere else, promise.

Feel free to send your feedback and continue the work...

xhost+

Qba
Posts: 9
Joined: 2003-12-06 08:21
Location: Poland

Post by Qba » 2004-04-19 15:24

and what about a ban list for downloads. i will tel you a stroy :wink:

i often download a set of files - like episodes or music - when i do that i download form many users at the same time, (they add through search on the common keyword, ex. futurama for futurama episodes) but... among many, many users that have most of the collection and are added to potential sources for myne download, there are some which are quite slow. when i look through the list i can see the same people "blocking" a file witch would have better hosts to download from, and i have to get rid of them all the time...

in esence - if there would be a way to tell dc "well download the files i listed in the download quete but DONT use any of the folowing users do download them from" :wink:

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-04-19 19:24

Qba wrote:i will tel you a stroy


No need, it's in the feature tracker already (I ask people to search there in the sticky post at the top of this forum):
[ 771569 ] manually label sources as preferred or to be avoided

Qba
Posts: 9
Joined: 2003-12-06 08:21
Location: Poland

Post by Qba » 2004-04-20 10:31

GargoyleMT wrote:No need, it's in the feature tracker already (I ask people to search there in the sticky post at the top of this forum):
[ 771569 ] manually label sources as preferred or to be avoided

i did read it... must have slipped :wink:
Qba

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Update

Post by xhost+ » 2004-05-03 12:46

The source distrib at http://jdcpp.free.fr was missing QueueFrame.h. It's now fixed.
Thanks to Toad for pointing this out.

xhost+

Simon F-L
Posts: 4
Joined: 2003-12-15 14:23

Post by Simon F-L » 2004-05-04 07:49

Have some probs.

When the timer starts to countdown all hubs disconnect and all dl's stops

And where are the options (lowest speed) supposed to be saved???

xhost+
Posts: 19
Joined: 2004-01-22 18:01
Location: in.the.middle.of.nowhere

Post by xhost+ » 2004-05-04 14:05

When the timer starts to countdown all hubs disconnect and all dl's stops


Seems strange. I've never experienced that... Did you compile it or did you use the binary?

And where are the options (lowest speed) supposed to be saved???


It's explained on the website. In the settings page there is an "Upload Speed Threshold" editbox you'll have to filled with the desired minimum upload rate.

xhost+

Oddish
Posts: 7
Joined: 2003-01-23 15:30

Post by Oddish » 2004-05-06 14:29

Great stuff! But will your version be detected as an illegal/modded version so we'll get banned from our favourite hubs?

And another question: which files do you need to replace? I just don't want to go through the hassle of losing my settings and my download queue.

Oddish
Posts: 7
Joined: 2003-01-23 15:30

Post by Oddish » 2004-05-06 17:08

Sorry for that second question. :oops: I didn't know there was only one file.

Oddish
Posts: 7
Joined: 2003-01-23 15:30

Post by Oddish » 2004-05-06 17:34

Ok, I've tried your modded version and I'm experiencing two problems so far.

1.Tthe "Remove source if below download threshold" option doesn't work. I right-click and select it, and the next time I right-click it still says "Remove source if below download threshold".

2. I can't manually add sources to files anymore.

Good effort, but it needs a little work.

EDIT:

3. While writing this message. It crashed!

toad
Posts: 8
Joined: 2003-02-18 02:48

Post by toad » 2004-05-11 06:04

The mod works beatifully for me after I received the missing file... The only change I implemented was to have download control the default.


/Toad

Trapper
Posts: 3
Joined: 2004-05-23 09:25

Post by Trapper » 2004-05-23 11:00

I posted something like this here and worked the idea out further:
http://dcplusplus.sourceforge.net/forum ... hp?t=10393

I'd like to be able to choose from which user I'm downloading, rather than DC++ just picking the first one online. It should pick the fastest instead. What about a 'properties' window for each file in which I can choose/delete/compare users for each file.
When it's downloading FileLists it can easily compare the speeds for each user. (Now I have to monitor manually which go fastest and then delete every user that is slow by right clicking - 20 times for 20 slow users :? )

It could also be set in this properties window that DC++ skips to another user if speed drops below a configurable level. And that being able to adjust for each file. So rare files will get a high speed and common files a low speed.

This will all make the queue.xml file a bit longer, but I think it would be great. There are so many fast slots around - it's just very difficult to find them.

Ace_Beast
Posts: 1
Joined: 2004-05-23 21:19

Post by Ace_Beast » 2004-05-23 21:35

Great job.

OptiMalXferz
Posts: 3
Joined: 2004-06-19 10:59

Better way

Post by OptiMalXferz » 2004-06-19 11:10


OptiMalXferz
Posts: 3
Joined: 2004-06-19 10:59

Babysitting downloads

Post by OptiMalXferz » 2004-06-19 11:29

. .close connection. Search for alternatives. That's all. Good?

Sometimes I leave my computer overnight only to find it downloaded 3% the next morning due to the fact that it was downloading at 11b/s


I decided to try bogstandard dc++ for a change instead of dc++ stealth to avoid changing mac address & aliases weekly and the occasional auto-ban hubs, but the lack of auto-disconnect slow user is very much the worst of 2 evils :twisted:

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Re: Babysitting downloads

Post by GargoyleMT » 2004-06-21 19:12

OptiMalXferz wrote:I decided to try bogstandard dc++ for a change instead of dc++ stealth to avoid changing mac address & aliases weekly and the occasional auto-ban hubs, but the lack of auto-disconnect slow user is very much the worst of 2 evils :twisted:

Er, did you miss the portion where xhost gave the URL to a DC++ mod that includes his changes? DC++ without dropping slow users and StealthDC++ with dropping aren't your only two choices. CZDC and PhantomDC both have dropping users too.

If you wanted to use a good client, you could.

OptiMalXferz
Posts: 3
Joined: 2004-06-19 10:59

Yea

Post by OptiMalXferz » 2004-06-23 15:48

Sounds good :)

Seade
Posts: 1
Joined: 2004-06-24 18:09
Location: Borås, Sweden
Contact:

Oh and oh!!!

Post by Seade » 2004-06-28 09:01

While you're at it, why not change it so that you can prioritize users with a certain string in their nickname, for example that this feature tries out all users that have the [BBB] or [10MBit] tag in front of their names first and then goes on to the next tag in the order of all the ones you can write? Get my drift?

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Re: Oh and oh!!!

Post by GargoyleMT » 2004-06-28 10:49

Seade wrote:While you're at it, why not change it so that you can prioritize users with a certain string in their nickname

That is only a small variation on this existing request:
[ 771569 ] manually label sources as preferred or to be avoided

duckfromhell
Posts: 1
Joined: 2004-07-10 07:42

download speed feature

Post by duckfromhell » 2004-07-10 07:54

hey there,

just read the threads on this topic and trying the feature now.
First of all i like to say that i find it a wonderfull feature which saves me a lot of irritation searching for faster users every time.

Second of all i like to make some suggestions to make this feature a little more user friendly;

1: is it possible to hook this feature up on the amount of users in your download que? For example that you can set it so that its only (and automatically) used when there are more then a given number of users to download from?
If this is possible, you can use it automatically for all the downloads, cause the proggie will not use it automatically when the amount of users which you can dl the file from is lower then your minimum requirement..

Another solution that would be great would be that this only works if there are other users with free slots in your queue for that file...In this case the proggie should check if there are more then # users in your queue and more then # from those users have free slots. IF thats the case and the dl is slow, he should disconnect and continue to try the next user.
This makes that you basicly will always have the fastest dl...(unless there are more users in queue with free slots that are all below the desired dl speed lol)

2: is it possible to let this feature make a log file, so you can see which users are closed for having a slow dl speed? Cause in this way you can check if the feature is doing what its supposed to do

greetings and keep up the good work :D

duckfromhell

PseudonympH
Forum Moderator
Posts: 366
Joined: 2004-03-06 02:46

Post by PseudonympH » 2004-07-10 23:08

From another thread:
PseudonympH wrote:It seems to me that most of these download management features people want will become irrelevant once multisource comes along. Personally, I'm willing to wait for one big thing to fix all the little ones.

carl0s
Posts: 9
Joined: 2004-08-02 05:51

Post by carl0s » 2004-08-02 05:56

This feature has it's pitfallsa if nopt implemented pproperly

please make sure to add verification as i do not want the feature to remove sources from rare files
say 5 or less source users online!!

Locked