Displaying dupes plzzz

Archived discussion about features (predating the use of Bugzilla as a bug and feature tracker)

Moderator: Moderators

Locked
PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Displaying dupes plzzz

Post by PI » 2004-02-12 05:34

Why not displaying dupes which are removed from my sharing list ?
3.14 times more little than his shadow ...

BSOD2600
Forum Moderator
Posts: 503
Joined: 2003-01-27 18:47
Location: USA
Contact:

Post by BSOD2600 » 2004-02-12 22:13

Why do you want to see them? What useful purpose would it serve? The only thing I would find useful is some notification somewhere that says how many dups it found and removed.

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

the purpose of displaying this files is obvious !

Post by PI » 2004-02-13 03:41

I've lot of files, and displaying dupes is a good idea to tidy my drives :)
And I think it's not difficult to add this function into DC++ because removing the dupes => filenames are known somewhere, so adding it to a List is not difficult , isn't it ?
I don't like having same files in differents directories, I don't want to have a "fake" share, even if the size is substracted ... the files already exist ...
please understand me :-)

:oops: I've probably made some mistakes. I'm still learning English ...
3.14 times more little than his shadow ...

gemmell1
Posts: 26
Joined: 2003-11-24 09:52

Post by gemmell1 » 2004-02-13 05:39

BSOD2600 wrote:Why do you want to see them? What useful purpose would it serve? The only thing I would find useful is some notification somewhere that says how many dups it found and removed.


I think that is what he means, he wants DC++ to tell him where the files are so he can manually remove them. I don't think he wants to show them in his share.

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Post by PI » 2004-02-13 06:04

yes it's that ! :lol:
3.14 times more little than his shadow ...

Gasman1015
Posts: 184
Joined: 2003-05-26 11:29
Location: UK

Post by Gasman1015 » 2004-02-13 13:22

Then use a file manager. Which DC++ is not. :roll:
Always remember you're unique, just like everyone else.

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Post by PI » 2004-02-13 14:29

GRRRRR It's easy to add this function, all the base is done ...
3.14 times more little than his shadow ...

Gasman1015
Posts: 184
Joined: 2003-05-26 11:29
Location: UK

Post by Gasman1015 » 2004-02-13 14:59

If it's so easy, supply a patch. :) :wink:
Always remember you're unique, just like everyone else.

Twink
Posts: 436
Joined: 2003-03-31 23:31
Location: New Zealand

Post by Twink » 2004-02-13 18:45

I'd agree that there doesn't seem to be alot of code needed for this, except where would it be displayed? a new window? a new log file?

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Post by PI » 2004-02-13 19:01

I think display dupes files list in a new window will be the best (window accessible by clicking on a button placed in sharing tab in settings , dupes files list refreshed when global list is generated)
3.14 times more little than his shadow ...

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-02-14 18:41

There are some changes in 0.307 that make it a little easier to add "system log"-like messages. I'll code this and submit it with one of my normal patches to arne.

(In the future, please don't use "easy" in a request for a feature... Essentially calling someone lazy [whether rightfully or wrongfully] is a poor way to motivate them to do something for you for free.)

Wisp
Posts: 218
Joined: 2003-04-01 10:58

Post by Wisp » 2004-02-18 04:05

would be a bad idea to automatically remove dupes

let's give some examples..

you have a game, like a car racing game, you shared the whole install directory like it appears on the install-cd

the cd has multiple directories with wave files which are needed during the game, there is a possibility that a wave file appears more than one time in different directories, when dc++ deletes all the dupes, the game can be corruptes because it misses files

another example is when you have a lot of complete mp3 albums, but you also made some personal compilations.. the chance is that dc++ first find the mp3 in the compilation folder, and then deletes the same mp3 on all the seperate albums the mp3 appears

that way you get a lot of incomplete albums (which is ver annoying for a user when he finds out there is a missing mp3 in the album while the user he downloaded from is already offline)

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-02-18 05:44

Not true.

Settings --> Advanced --> Remove dupes completely from your share (otherwise only their size is subtracted, but the files can be seen by others)

That incredibly verbose option seems to cover what you are talking about Wisp.
The world is coming to an end. Please log off.

DC++ Guide | Words

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-02-18 05:46

GargoyleMT wrote:There are some changes in 0.307 that make it a little easier to add "system log"-like messages. I'll code this and submit it with one of my normal patches to arne.

Cool. Generic logging system = good. Can you please point out what part of the code it's in?
The world is coming to an end. Please log off.

DC++ Guide | Words

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-02-19 11:48

TheParanoidOne wrote:Cool. Generic logging system = good. Can you please point out what part of the code it's in?


The basic functionality is LogManager::getInstance()->message(string);

In BCDC's code, I extended it to keep 10 of the messages in the tooltip... I may reduce that and add a SystemLog window (that only remembers messages while it's open)... I'm not sure yet. I also inserted a simple logging line right before the fire() in message(), dependent upon a boolean setting.

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

System Log: Good Idea !

Post by PI » 2004-02-22 15:06

The logging is a good idea !

Back to my question : A solution is putting the removed dupes filenames into the system log instead of creating a new window just for this feature ...
3.14 times more little than his shadow ...

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Re: System Log: Good Idea !

Post by GargoyleMT » 2004-02-22 22:42

PI wrote:The logging is a good idea !

Back to my question : A solution is putting the removed dupes filenames into the system log instead of creating a new window just for this feature ...


Hashing is included in the log, as are start/ending a file list refresh, and disconnecting users who leave the hub.

Code: Select all

C:\Program Files\DC++\Logs>tail system.log

2004-02-22 07:52:18: File list refresh finished
2004-02-22 08:53:07: File list refresh initiated
2004-02-22 08:53:18: File list refresh finished
2004-02-22 09:46:46: Disconnected user leaving the hub: Ichitaka_Seto
2004-02-22 09:54:07: File list refresh initiated
2004-02-22 09:54:30: File list refresh finished
2004-02-22 10:55:07: File list refresh initiated
2004-02-22 10:55:25: File list refresh finished
2004-02-22 11:56:07: File list refresh initiated

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Post by PI » 2004-02-23 02:59

... I don't see some filenames in your system.log ...
3.14 times more little than his shadow ...

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-02-28 12:33

PI wrote:... I don't see some filenames in your system.log ...

There are none, I was showing ParanoidOne what I'd done so far, not demonstrating what I said I'd code for you. =)

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Post by PI » 2004-03-01 01:25

lol :lol:
3.14 times more little than his shadow ...

BSOD2600
Forum Moderator
Posts: 503
Joined: 2003-01-27 18:47
Location: USA
Contact:

Post by BSOD2600 » 2004-03-12 14:52

Ok, the addition of knowing what dupes are being removed is nice, but it still could be improved a little.

Code: Select all

2004-03-12 10:48:45: Duplicate file will not be shared: Acdc - Problem child.mp3 (size: 5484853 bytes)
2004-03-12 10:48:45: Duplicate file will not be shared: Acdc - Let there be rock.mp3 (size: 5852721 bytes)
2004-03-12 10:48:45: Duplicate file will not be shared: Acdc - Hell ain't a bad place to be.mp3 (size: 4008696 bytes)
2004-03-12 10:48:45: Duplicate file will not be shared: Acdc - Bad boy boogie.mp3 (size: 4311703 bytes)
2004-03-12 10:48:45: Duplicate file will not be shared: folder.jpg (size: 18033 bytes)
2004-03-12 10:48:45: Duplicate file will not be shared: folder.jpg (size: 18033 bytes)
2004-03-12 10:48:46: Duplicate file will not be shared: Maynard Ferguson - 05 - Fiesta.mp3 (size: 7742754 bytes)
2004-03-12 10:48:46: Duplicate file will not be shared: Maynard Ferguson - 01 - Primal Scream.MP3 (size: 10255116 bytes)
2004-03-12 10:48:46: Duplicate file will not be shared: 03 - Maná - Cachito.mp3 (size: 4616280 bytes)


Thats what I get in the log file. It sure would be nice if it told which other file its a dup of and the full path of each.

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-12 19:40

BSOD2600 wrote:Thats what I get in the log file. It sure would be nice if it told which other file its a dup of and the full path of each.


Full path? Ok, that can be done (though I haven't written the code). The loop is fairly simple currently, so I'm not sure how you can print "the original" file just once if you have multiple duplicates of it shared...

BSOD2600
Forum Moderator
Posts: 503
Joined: 2003-01-27 18:47
Location: USA
Contact:

Post by BSOD2600 » 2004-03-12 20:29

It just saves me the hassle of using crappy windows search to try and find the same named file. DC++ thinks files are dups if they are the exact same byte size or does it look at the filenames too?

Removing the file sorta creates a problem for those who are downloading file sets (ok, an album in my case) since DC++ has now removed one track from it. Yes, they can do a search for that specific missing track, but that creates more hassle.

Twink
Posts: 436
Joined: 2003-03-31 23:31
Location: New Zealand

Post by Twink » 2004-03-12 21:30

BSOD2600 wrote:It just saves me the hassle of using crappy windows search to try and find the same named file. DC++ thinks files are dups if they are the exact same byte size or does it look at the filenames too?

Removing the file sorta creates a problem for those who are downloading file sets (ok, an album in my case) since DC++ has now removed one track from it. Yes, they can do a search for that specific missing track, but that creates more hassle.


maybe there should be an option to leave the file in the list but just not count it towards your share total?

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-12 21:32

The dupe check works on exact name and filesize, though hopefully that can be eliminated in favor of hash-based duplicates. =)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-12 21:33

Twink wrote:maybe there should be an option to leave the file in the list but just not count it towards your share total?

That's tongue in cheek, right?

Code: Select all

SETTINGS_REMOVE_DUPES, // "Remove dupes completely from your share (otherwise, only their size is subtracted, but the files can be seen by others)"

YaRi
Posts: 18
Joined: 2003-08-19 10:52

Post by YaRi » 2004-03-27 01:46

GargoyleMT wrote:The dupe check works on exact name and filesize, though hopefully that can be eliminated in favor of hash-based duplicates. =)

Could this be extended so, that when downloading files, which I already have, would give a duplicate error:
"Error downloading: You already have this file".
The comparison would be based on hash of course.

Todi
Forum Moderator
Posts: 699
Joined: 2003-03-04 12:16
Contact:

Post by Todi » 2004-03-27 05:28

That's actually a pretty good idea.. i don't know how many dupes i download =) 'course, it would either require you to have the hash before loading, or do the comparison after the file has already loaded (which makes it a bit unnecessary)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-03-27 16:27

YaRi wrote:"Error downloading: You already have this file".

Agreed - check out this RFE for that:

[ 896494 ] Eradicate duplicate downloads

PI
Posts: 9
Joined: 2004-02-12 05:29
Location: Rennes (FRANCE)
Contact:

Thanks

Post by PI » 2004-05-13 15:51

Thank you you all for your help !
I'm looking forward to seeing this changes ...

+
3.14 times more little than his shadow ...

foxyshadis
Posts: 15
Joined: 2004-04-12 19:53
Contact:

Post by foxyshadis » 2004-05-15 12:03

Now that TTH is implemented it makes this thread's feature far more accurate. I'd have posted my new thread last week in here instead if I'd seen it. ^.~

Locked