Download not starting after an alternative source found

Archived discussion about features (predating the use of Bugzilla as a bug and feature tracker)

Moderator: Moderators

Locked
paka
Posts: 45
Joined: 2004-12-27 19:20

Download not starting after an alternative source found

Post by paka » 2005-02-01 21:30

The steps to reproduce this bug are:

1. Enqueue a file found in search frame (add the file to the queue with user A as a source).
2. Remove source A, leaving the file in the queue. "No users to download from".
3. Search for alternative locations. The new sources B, C and D are added to the queue automatically ("Waiting [...]" instead of "No users [...]"). The original source A wasn't added automatically despite the TTH matching (this is probably how it should be when I remove the source manually). However, there are no download attempts from the new users B, C and D that were added.

Client versions (shouldn't be important, but here it goes):
- downloading:
DC++ 0.6685 CVS 2005-02-01 or DC++ 0.668 (verified on both);
- sharing:
user A on BCDC++ 0.401b,
users B and C - DC++ 0.668,
user D - DC++ 0.667.

This bug seems to be closely related to http://dcplusplus.sourceforge.net/forum ... hp?t=11192, but it may be not the same one because (in my test) there was a download attempt after I readded the source user A manually. Furthermore, it's not so easy to check if this one is a duplicate of that one because that problem occurs after a period of the source user being offline and bug reproduction conditions aren't clear to me.

I've reported this bug to Bugzilla @ http://dcplusplus.sourceforge.net/cgi-b ... cgi?id=438.

paka
Posts: 45
Joined: 2004-12-27 19:20

Post by paka » 2005-02-01 23:51

I've sent a patch for this bug to Arne and to Bugzilla. The diff is created against v0.6685[3] CVS 2005-02-01.

The patch uses the same method of requesting a connection as QueueManager::add already does. Tested & works :)

I've checked the whole source for addSource occurences and there doesn't seem to be another place where a source was added without requesting a download connection. So the bug described in http://dcplusplus.sourceforge.net/cgi-b ... cgi?id=406 and http://dcplusplus.sourceforge.net/forum ... hp?t=11192 should also be solved with this patch. Therefore bug #438 can probably be marked as a duplicate of #406.

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-02-03 13:40

Pick either bugzilla or the forum, in the future, please. As is, you're doubling the work required to keep up with your issue.

paka
Posts: 45
Joined: 2004-12-27 19:20

Post by paka » 2005-02-04 21:45

I'll try to minimise duplicated content. Seems to me that Bugzilla is best for uploading patches for reviewing by others and the forum for the rest.

A patch for this bug has been added to DC++ 0.670 release.

Locked