File not available from duplicate virtual folder names

Archived discussion about features (predating the use of Bugzilla as a bug and feature tracker)

Moderator: Moderators

Locked
Lundis
Posts: 53
Joined: 2004-06-30 11:47

File not available from duplicate virtual folder names

Post by Lundis » 2004-10-15 17:27

I found something strange, three folders called complete and video from this user (haven't talked to him/her).
Version was 0.4034
When you add a new folder you can't type in a virtual folder names that's already used.
But what if you already have two or more folders of the same name already shared? (before installing 0.4034 or the previous one)
Will they get an 'a' and 'b' after the name? My guess is that it doesn't.

The effects of this is that you can only download from one of the folders of the same name, file not available for the others. I tested this in a resonably certain way.
If this is a valid bug I might post it on bugzilla but I'm not sure. I don't wanna restart dc++ and mess with dcplusplus.xml to test it.

http://hem.bredband.net/b140683/somedude.xml.bz2

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-10-15 19:58

DC++ will also let you put $ in the virtual name, as per an earlier complaint.

Lundis
Posts: 53
Joined: 2004-06-30 11:47

Post by Lundis » 2004-10-16 02:16

Am I supposed to make every user with duplicated folder names to do that?

If we can back on the subject, I messed with my settings file.

Code: Select all

<Directory Virtual="apps">C:\arkiv\apps\</Directory>
<Directory Virtual="apps">C:\arkiv\Incoming\logs\</Directory>
Added the folder logs, named it apps in dcplusplus.xml as its virtual name and PRESTO!
Two folders called apps, and I can probably only download from one of them.
My theory is that when upgrading to a version with virtual folders and you have folders with the same name you get this and dc++ doesn't do a simple check for duplicates or even add the letter a, b, and c like it usually does.


EDIT:
Woohoo! fixed now, will probably go in the next version. Thanks to Todd (maybe he's called Todi here)
http://dcplusplus.sourceforge.net/cgi-b ... cgi?id=227

joakim_tosteberg
Forum Moderator
Posts: 587
Joined: 2003-05-07 02:38
Location: Sweden, Linkoping

Post by joakim_tosteberg » 2004-10-18 00:36

Lundis wrote:EDIT:
Woohoo! fixed now, will probably go in the next version. Thanks to Todd (maybe he's called Todi here)
http://dcplusplus.sourceforge.net/cgi-b ... cgi?id=227
Okey now, sit down take a deep breath because I'm going to tell you something
Todd todd Pederzani is really our own Gargoyle MT!

Lundis
Posts: 53
Joined: 2004-06-30 11:47

Post by Lundis » 2004-10-18 05:33

Noted, thanks. It's not easy to guess what everyones names are in so many places.

And I'm sitting down comfortably. :)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-10-18 10:48

The final solution, though, is not to make the new directories unique, but to not share them. This is solely a problem with people upgrading from before 0.4033. They can add the folders to their share again (once they notice) under a unique name.

Lundis
Posts: 53
Joined: 2004-06-30 11:47

Post by Lundis » 2004-10-18 16:57

So duplicated folders will be unshared without notification?
If so: Cool.

This seems a bit different to what dc++ usually does. If there's a bad setting, dc++ does nothing.
Like it's not possible to share the incomplete downloads folder (directly) but if it's already shared nothing will be done.
(and other examples I can't think of right now)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2004-10-24 15:02

Lundis wrote:So duplicated folders will be unshared without notification?
Yes. Loading the share happens early in the startup process, so it'd be hard to notify the user.

Locked