The view as text feature

Archived discussion about features (predating the use of Bugzilla as a bug and feature tracker)

Moderator: Moderators

Locked
pcw
Posts: 7
Joined: 2004-07-20 10:14

The view as text feature

Post by pcw » 2004-07-20 10:24

Right now you have the possibility of using the OEM monospaced font for viewing text files. But the majority of the text files (so called .nfo files) are using a SYSTEM font.

So I'm wondering if it would be possible in future versions of DC++ to be able to change the font for viewing text files?

Regards,
Peter

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Re: The view as text feature

Post by TheParanoidOne » 2004-07-20 11:17

pcw wrote:using the OEM monospaced font for viewing text files. But the majority of the text files (so called .nfo files) are using a SYSTEM font.
I don't understand the distinction you are making here. When you talk about SYSTEM, are you talking about the Windows font called "System"? If so, that is a monospaced font.

I understand the request for setting your own font, but can you please elaborate on the above..
The world is coming to an end. Please log off.

DC++ Guide | Words

pcw
Posts: 7
Joined: 2004-07-20 10:14

Re: The view as text feature

Post by pcw » 2004-07-20 11:35

TheParanoidOne wrote:
pcw wrote:using the OEM monospaced font for viewing text files. But the majority of the text files (so called .nfo files) are using a SYSTEM font.
I don't understand the distinction you are making here. When you talk about SYSTEM, are you talking about the Windows font called "System"? If so, that is a monospaced font.

I understand the request for setting your own font, but can you please elaborate on the above..
What I mean is that when I view text files for instance in notepad I've set the font to SYSTEM (OEM/DOS) to be able to view them "correctly" in all their ascii glory :)

I figured setting that font as default font when viewing text files in DC++ would "correct" the viewing but then again you can only use "Use OEM monospaced font" which doesn't seem to do the job correctly..

Here's a screendump so you can see what I'm talking about..

Image

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Re: The view as text feature

Post by TheParanoidOne » 2004-07-20 12:55

pcw wrote:you can only use "Use OEM monospaced font" which doesn't seem to do the job correctly..
Define "correctly". Shouldn't all monospace font by their very nature (monospaced!) show ASCII art in exactly the same way, albeit with a different font style?
pcw wrote:Here's a screendump so you can see what I'm talking about..
Unfortunately that doesn't help me. :) Are you showing what you deem to be "correct" behaviour or "incorrect" behaviour in that screenshot?

Perhaps two "correct" and "incorrect" pictures would be more appropriate?
The world is coming to an end. Please log off.

DC++ Guide | Words

pcw
Posts: 7
Joined: 2004-07-20 10:14

Post by pcw » 2004-07-20 14:19

Okay I'll try to give it another try ;)

Here is what the .nfo file looks like in DC++ using OEM monospaced font:

Image

And here is what the same .nfo file looks like in notepad using SYSTEM font:

Image

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-20 18:14

Ah, I get you now. Although to be pedantic, you are using the Terminal font and not the System font. If you had mentioned Terminal at first, I might have clicked earlier.

Thanks for the pics. It's clear now. :)
The world is coming to an end. Please log off.

DC++ Guide | Words

pcw
Posts: 7
Joined: 2004-07-20 10:14

Post by pcw » 2004-07-20 18:18

TheParanoidOne wrote:Ah, I get you now. Although to be pedantic, you are using the Terminal font and not the System font. If you had mentioned Terminal at first, I might have clicked earlier.

Thanks for the pics. It's clear now. :)
My bad :)

I meant of course Terminal font :)

So do you know anything about this little predicament?

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-20 18:39

Oh, I guess I should have mentioned this earlier: If you want to request this feature, add it to the feature tracker at

http://dcplusplus.sourceforge.net/bugs

Make sure you set the severity as enhancement.
The world is coming to an end. Please log off.

DC++ Guide | Words

pcw
Posts: 7
Joined: 2004-07-20 10:14

Post by pcw » 2004-07-20 19:49

TheParanoidOne wrote:Oh, I guess I should have mentioned this earlier: If you want to request this feature, add it to the feature tracker at

http://dcplusplus.sourceforge.net/bugs

Make sure you set the severity as enhancement.
Done it :)

Okay so thanks for your help :)

Peace.

Sedulus
Forum Moderator
Posts: 687
Joined: 2003-01-04 09:32
Contact:

Post by Sedulus » 2004-07-21 05:50

that's odd..

relevant code:

Code: Select all

[2:wza:windows]$ grep monoFont * 2>/dev/null
TextFrame.cpp:  ctrlPad.SetFont(WinUtil::monoFont);
WinUtil.cpp:HFONT WinUtil::monoFont = NULL;
WinUtil.cpp:    monoFont = (HFONT)::GetStockObject(BOOLSETTING(USE_OEM_MONOFONT)?OEM_FIXED_FONT:ANSI_FIXED_FONT);
WinUtil.cpp:    ::DeleteObject(monoFont);
WinUtil.h:      static HFONT monoFont;
from: http://msdn.microsoft.com/library/en-us ... s_1t10.asp
ANSI_FIXED_FONT Windows fixed-pitch (monospace) system font.
OEM_FIXED_FONT Original equipment manufacturer (OEM) dependent fixed-pitch (monospace) font.
over here the OEM font _is_ Terminal, that's why I chose the OEM-font.
http://dc.selwerd.nl/hublist.xml.bz2
http://www.b.ali.btinternet.co.uk/DCPlusPlus/index.html (TheParanoidOne's DC++ Guide)
http://www.dslreports.com/faq/dc (BSOD2600's Direct Connect FAQ)

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-21 06:06

After experimenting, it seems that DC++ uses a Courier type font, as shown in the "incorrect" picture above. Whereas BCDC++ uses the OEM font as shown in the "correct" picture.

Note that the toggle does nothing on either.
The world is coming to an end. Please log off.

DC++ Guide | Words

Sedulus
Forum Moderator
Posts: 687
Joined: 2003-01-04 09:32
Contact:

Post by Sedulus » 2004-07-21 06:12

this page ( http://msdn.microsoft.com/library/en-us ... t_3pbo.asp ) even explicitly states that it should have the IBM charset (those that the NFO's use).
OEM_FIXED_FONT Specifies a monospace font based on an OEM character set. For IBM computers and compatibles, the OEM font is based on the IBM PC character set.
besides.. the ansi font should be monospaced too (courier over here). I would guess that your fonts are messed up somehow.
http://dc.selwerd.nl/hublist.xml.bz2
http://www.b.ali.btinternet.co.uk/DCPlusPlus/index.html (TheParanoidOne's DC++ Guide)
http://www.dslreports.com/faq/dc (BSOD2600's Direct Connect FAQ)

Sedulus
Forum Moderator
Posts: 687
Joined: 2003-01-04 09:32
Contact:

Post by Sedulus » 2004-07-21 06:17

TheParanoidOne wrote:Note that the toggle does nothing on either.
did you restart dc++?
http://dc.selwerd.nl/hublist.xml.bz2
http://www.b.ali.btinternet.co.uk/DCPlusPlus/index.html (TheParanoidOne's DC++ Guide)
http://www.dslreports.com/faq/dc (BSOD2600's Direct Connect FAQ)

Sedulus
Forum Moderator
Posts: 687
Joined: 2003-01-04 09:32
Contact:

Post by Sedulus » 2004-07-21 06:21

TheParanoidOne wrote:a Courier type font, as shown in the "incorrect" picture above.
huh?
http://hem.bredband.net/b247083/temp/dc.jpg
that is not courier.. that's some variable width font
http://dc.selwerd.nl/hublist.xml.bz2
http://www.b.ali.btinternet.co.uk/DCPlusPlus/index.html (TheParanoidOne's DC++ Guide)
http://www.dslreports.com/faq/dc (BSOD2600's Direct Connect FAQ)

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-21 06:55

Sedulus wrote:
TheParanoidOne wrote:Note that the toggle does nothing on either.
did you restart dc++?
D'Oh! I completely forgot that you needed to do that with the Appearance page. My bad. :oops: I guess that comment can be disregarded for the moment.
Sedulus wrote:
TheParanoidOne wrote:a Courier type font, as shown in the "incorrect" picture above.
huh?
http://hem.bredband.net/b247083/temp/dc.jpg
that is not courier.. that's some variable width font
It's not variable width. It's monospaced.
The world is coming to an end. Please log off.

DC++ Guide | Words

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-07-21 07:11

I retract my earlier statement about the toggle. Restarting did the trick.
The world is coming to an end. Please log off.

DC++ Guide | Words

foxyshadis
Posts: 15
Joined: 2004-04-12 19:53
Contact:

Post by foxyshadis » 2004-08-01 10:45

Sedulus wrote:
TheParanoidOne wrote:a Courier type font, as shown in the "incorrect" picture above.
huh?
http://hem.bredband.net/b247083/temp/dc.jpg
that is not courier.. that's some variable width font
It's not variable width. It's monospaced.[/quote]
It's Arial / MS Sans Serif, Window's ugly-as-sin default sans-serif variable-width font in textboxes. (Just looks mono when it's a bunch of the same or similar character.)

TheParanoidOne
Forum Moderator
Posts: 1420
Joined: 2003-04-22 14:37

Post by TheParanoidOne » 2004-08-01 11:01

I'm being made to look blind now. That is not the same screenshot I looked at. It now shows a variable width font, but when I posted my comment, the image had a fixed width font. :(
The world is coming to an end. Please log off.

DC++ Guide | Words

pcw
Posts: 7
Joined: 2004-07-20 10:14

Post by pcw » 2004-08-01 16:57

What's going on in here? :)

I haven't been here for a few days.

Is the font issue fixed? :)

foxyshadis
Posts: 15
Joined: 2004-04-12 19:53
Contact:

Post by foxyshadis » 2004-08-01 20:40

Haha, paranoid. Maybe you have good reason to use that name. xD

Sedulus
Forum Moderator
Posts: 687
Joined: 2003-01-04 09:32
Contact:

Post by Sedulus » 2004-08-02 03:25

pcw wrote:Is the font issue fixed? :)
I see no font issue (except on your machine).
according to everything I find on the internet, both fonts should be fixed width, with the ANSI font being Courier and the OEM font being Terminal (or at least IBM/cp437)

I did however see other fonts in the image? are you using some kind of skin? could you disable/uninstall/default that skin and see if the fonts are corrected?
http://dc.selwerd.nl/hublist.xml.bz2
http://www.b.ali.btinternet.co.uk/DCPlusPlus/index.html (TheParanoidOne's DC++ Guide)
http://www.dslreports.com/faq/dc (BSOD2600's Direct Connect FAQ)

pcw
Posts: 7
Joined: 2004-07-20 10:14

Post by pcw » 2004-08-02 08:25

Sedulus wrote:
pcw wrote:Is the font issue fixed? :)
I see no font issue (except on your machine).
according to everything I find on the internet, both fonts should be fixed width, with the ANSI font being Courier and the OEM font being Terminal (or at least IBM/cp437)

I did however see other fonts in the image? are you using some kind of skin? could you disable/uninstall/default that skin and see if the fonts are corrected?
I'm using a patched uxtheme.dll to use other .msstyles than the windows default.

Anyway I reverted back to the classic windows xp .msstyle and it still doesn't draw the ascii "correctly" for me :(

Locked