CVS todo list?

A private forum for us Super-Humans, I even trust you to be able to edit your own posts =)

Moderator: Moderators

Locked
GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

CVS todo list?

Post by GargoyleMT » 2005-12-13 12:07

Here's my list of stuff that seems to amiss in CVS:
    * The "hub name" seems inconsistent; it copies two words for "DCDev Private", but only one for another hub I'm on "VGMC Pocket" (ah, there's much more after "Private", but with "Pocket", it's the end of the string
    * "Your" nick in PM seems to be using the one from Settings instead of the Favorite Hubs
    * "Last Seen" in the Favorite User Manager is never set, seemingly
    * Favorite Users aren't updated as you quit/join hubs (maybe when they go offline and online again)
    * I got 4 blank user names in the Favorite User window when I restarted DC++. One of the missing users was me, though I'm not sure who the other 3 were.
    * Remove in favorites is still broken because it doesn't iterate from the beginning each time.
    * your tag still reads "P"
    * "Go to directory" in ADLSearch results seems to have been broken again in 0.674
    * "Match Queue" button in 0.674 seems to be disabled

Additions welcome... I just don't want a release where we'll have support issues right off the bat.
Last edited by GargoyleMT on 2005-12-15 11:57, edited 1 time in total.

Pothead
Posts: 223
Joined: 2005-01-15 06:55

Post by Pothead » 2005-12-13 13:39

Socket Exception: Connection closed (debug mode, Connection Closed in Release mode), when trying to get a filelist of an older client should be fixed i think, if you wanna minimize support issues. :)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-13 13:44

Old file list? Odd. There's probably still a $UGetBlock disconnection issue around somewhere too.

Do you have any more details about how to reproduce it, or should it be pretty obvious?

joakim_tosteberg
Forum Moderator
Posts: 587
Joined: 2003-05-07 02:38
Location: Sweden, Linkoping

Post by joakim_tosteberg » 2005-12-13 15:13

I made som quick tests on it and it seems to alawys hapen when downloading filelists from version 0.401 of DC++ and probably 0.402 as well but there was only one person using that client during my test. Version 0.403 seems to work fine.

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-13 15:24

joakim_tosteberg wrote:I made som quick tests on it and it seems to alawys hapen when downloading filelists from version 0.401 of DC++ and probably 0.402 as well but there was only one person using that client during my test. Version 0.403 seems to work fine.

That might be the $UGetBlock thing. I don't think it being fixed is in the changelog (I'll probably patch that in), but 0.402 sounds about right.

ullner
Forum Moderator
Posts: 333
Joined: 2004-09-10 11:00
Contact:

Post by ullner » 2005-12-13 17:38

'0.05' in Max upload speed is there twice. And in PublicHublistDlg.h;

Code: Select all

         LineDlg hublist;
         hublist.title = _T("Hublist");
         hublist.description = _T("Edit the hublist");

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-15 11:58

ullner wrote:'0.05' in Max upload speed is there twice. And in PublicHublistDlg.h;

Ah, non-localized strings. And the first 0.05 should be 0.005, probably.

ullner
Forum Moderator
Posts: 333
Joined: 2004-09-10 11:00
Contact:

Post by ullner » 2005-12-15 13:04

When logging in as operator in a hub, the "operator part" of the tag isn't updated. The "registered-part" is though. (I don't know a better way to explain it... Just log into a hub as operator and look at your tag.)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-16 12:54

It seems to be updated eventually. Perhaps this is an artifact of the changes to the sending of myinfo?

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-20 16:52

Another:
* Reconnecting on ADC hubs... doesn't work. presumably the state needs to be reset, and because it's not the login breaks.

ullner
Forum Moderator
Posts: 333
Joined: 2004-09-10 11:00
Contact:

Post by ullner » 2005-12-20 17:14

You mean automatic reconnect or manual reconnect? (The latter work fine here.)

By the way, NI and DE coming from the hub doesn't show in the hubframe. (ADC)

Further: people quitting doesn't seem to be updated in the user list. (ADC)

GargoyleMT
DC++ Contributor
Posts: 3212
Joined: 2003-01-07 21:46
Location: .pa.us

Post by GargoyleMT » 2005-12-20 17:49

Manual, but cologic says it works for him, so I must be missing a CVS update or have otherwise broken it.

ullner
Forum Moderator
Posts: 333
Joined: 2004-09-10 11:00
Contact:

Post by ullner » 2005-12-21 20:37

Connection type is never displayed in the user list.

ullner
Forum Moderator
Posts: 333
Joined: 2004-09-10 11:00
Contact:

Post by ullner » 2005-12-22 22:00

* The client CID change after each startup.

cologic
Programmer
Posts: 337
Joined: 2003-01-06 13:32
Contact:

Post by cologic » 2005-12-22 23:34

Some wouldn't regard that as a bug...

Big Muscle
Posts: 72
Joined: 2004-01-23 14:45

Post by Big Muscle » 2006-08-24 07:41

* Identity class isn't thread-safe. Two threads can access to "info" map which can result in crash in Identity::get/set

I think it's connected with these crashes:
http://dcpp.net/crash/view_crash.php?id=10279
http://dcpp.net/crash/view_crash.php?id=10276
http://dcpp.net/crash/view_crash.php?id=10277

Locked