Search found 45 matches

by paka
2005-02-04 21:45
Forum: Feature Discussion (Archived)
Topic: Download not starting after an alternative source found
Replies: 3
Views: 2979

I'll try to minimise duplicated content. Seems to me that Bugzilla is best for uploading patches for reviewing by others and the forum for the rest.

A patch for this bug has been added to DC++ 0.670 release.
by paka
2005-02-02 19:20
Forum: Feature Discussion (Archived)
Topic: Remove user from queue removes more than one user
Replies: 2
Views: 1635

Thanks for verifying. Hm, strange. My queue was empty for the test (only the tested file was there), but this doesn't seem to change anything because I did another test with 0.668 2004-11-30 release and got the same result (both sources deleted). I've checked the existence of this problem quite a fe...
by paka
2005-02-02 15:15
Forum: Feature Discussion (Archived)
Topic: Remove user from queue removes more than one user
Replies: 2
Views: 1635

Remove user from queue removes more than one user

The problem is present in DC++ 0.668 (and earlier, most likely) and DC++ 0.6685[3] CVS 2005-02-01. My steps to reproduce this bug: 1. Download the filelist of user A and enqueue one file. 2. Search for alternative sources of the file from queue frame (one new source - user B - was found in my test a...
by paka
2005-02-02 01:31
Forum: Feature Discussion (Archived)
Topic: match queue not working after source removed
Replies: 8
Views: 3716

Oops, this bug seems to be a duplicate of http://dcplusplus.sourceforge.net/cgi-bin/bugzilla/show_bug.cgi?id=240.

The problem remains unsolved, though.
by paka
2005-02-01 23:51
Forum: Feature Discussion (Archived)
Topic: Download not starting after an alternative source found
Replies: 3
Views: 2979

I've sent a patch for this bug to Arne and to Bugzilla. The diff is created against v0.6685[3] CVS 2005-02-01. The patch uses the same method of requesting a connection as QueueManager::add already does. Tested & works I've checked the whole source for addSource occurences and there doesn't seem...
by paka
2005-02-01 21:30
Forum: Feature Discussion (Archived)
Topic: Download not starting after an alternative source found
Replies: 3
Views: 2979

Download not starting after an alternative source found

The steps to reproduce this bug are: 1. Enqueue a file found in search frame (add the file to the queue with user A as a source). 2. Remove source A, leaving the file in the queue. "No users to download from". 3. Search for alternative locations. The new sources B, C and D are added to the queue aut...
by paka
2005-02-01 20:34
Forum: Feature Discussion (Archived)
Topic: Feature - Force Source
Replies: 2
Views: 1640

If the new source is different to the one you were downloading from before, your file may disintegrate. Some of such files are re-shared and we don't want corrupted files in the network.

You can download the file to another location.
by paka
2005-02-01 18:15
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

The patch v2 has been added to CVS development version 0.669 2005-02-01.
by paka
2005-02-01 17:32
Forum: Feature Discussion (Archived)
Topic: Downloaded tree does not match TTH root
Replies: 0
Views: 2850

Downloaded tree does not match TTH root

I'll write in steps what I have done: 1. Enqueued one file in DC++ 0.668. The source user A was then removed automatically (don't know the reason - was AFK), though there were no problems with downloading other parts of the release from him before. 2. Switched to v0.6685 CVS 2005-01-20 and readded m...
by paka
2005-01-27 21:27
Forum: Feature Discussion (Archived)
Topic: match queue not working after source removed
Replies: 8
Views: 3716

You're confusing file share refreshing with file list generation - they're separate actions, though the list generation can depend on share refreshing. Right, that was my habit to consider those two actions together as they were carried out in older versions. However, the problem is that I do a Mat...
by paka
2005-01-27 17:06
Forum: Feature Discussion (Archived)
Topic: How to make hashing more practical
Replies: 21
Views: 6705

Right, not that easy then. My mistake that I haven't analysed how the new resume works... Thanks for checking it.
by paka
2005-01-26 15:15
Forum: Feature Discussion (Archived)
Topic: How to make hashing more practical
Replies: 21
Views: 6705

However, that would require writing code to download and check arbitrary parts of files, which is a decent percentage of the work needed for multisource. Because of this, it probably won't be implemented until multisource downloads are..... Please read my previous post in this topic. The developmen...
by paka
2005-01-20 19:12
Forum: Feature Discussion (Archived)
Topic: How to make hashing more practical
Replies: 21
Views: 6705

Re: How to make hashing more practical

The leaves are transferred between clients and allow sections of the file to be verified independent of the whole. but does dc++ as it is now , actualy have any use for this? Yes. The development version 0.669 makes use of segment checking: * Added advanced resume that detects and tries to repair r...
by paka
2005-01-20 18:21
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

I've modified QueueManager.cpp with this: @@ -861,6 +861,8 @@ directories.erase(q->getSources()[0]->getUser()); } + DownloadManager::getInstance()->abortDownload(q->getTarget()); + if(q->getStatus() == QueueItem::STATUS_RUNNING) &#...
by paka
2005-01-20 15:47
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

I've just finished writing a letter and sent it.
by paka
2005-01-20 15:02
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

Thanks, I've corrected this now. The rewritten and improved patch is available as the second attachment @ http://dcplusplus.sourceforge.net/cgi-bin/bugzilla/show_bug.cgi?id=431. The patch is for DC++ 0.669 CVS version.
by paka
2005-01-14 21:29
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

GargoyleMT wrote:You can use a different enum for the column name while still using ResourceManager::EXACT_SIZE...

True (second parameter of ctrlList.InsertColumn). That's how I did it in the new version of the patch.
by paka
2005-01-14 20:50
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

I've modified DownloadManager.cpp with this: @@ -905,6 +905,7 @@ if(d->getTarget() == aTarget) { dcassert(d->getUserConnection() != NULL); d->getUserConnection()->disconnect(); + QueueManager::getInstance()->putDownload(d, false); ...
by paka
2005-01-14 15:06
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

Also, there's code to delete the lists already in QueueManager::putDownload() Yes. AFAIK, this piece deletes the filelist when the transfer of a filelist was stopped, but the item remains in the queue. I've tried to copy it directly to the remove function, but in vain (even when I specified the fil...
by paka
2005-01-14 13:44
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

Have you checked if the file is still open? =) Most likely this is the problem. That's why I put that crappy slowdown loop I've tried to put the File::deleteFile call outside the remove function (specifically, in the piece of code where the event of Delete key pressed is handled), but the file rema...
by paka
2005-01-14 10:57
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

You're right, Todi. This would most likely be applied to bigger patches. However, I must stick to the fact that the one I'm presenting here is actually only an extension of the idea that is already present in vanilla DC++ (in Download queue frame and in Search frame). It's an analogy, so Arne should...
by paka
2005-01-13 22:12
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

I wrote a workaround for the problem. I know it's horrible. But it works for me QueueManager.cpp is the modified file. Here's the diff (Bugzilla seems to be down): @@ -847,10 +847,16 @@ void QueueManager::remove(const string& aTarget) throw() { string x; + string tname = &qu...
by paka
2005-01-13 22:05
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

I've sent a rewritten patch to Arne. It doesn't contain any line that appears in BCDC++. Also, it contains 2 new lines which deal with directory comparing and displaying directory size in bytes.
by paka
2005-01-13 18:19
Forum: Feature Discussion (Archived)
Topic: Unfinished downloads to Download Dir
Replies: 3
Views: 1534

Just set the incomplete files directory on the same partition as the complete files directory.
by paka
2005-01-13 16:24
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

I'm just trying to warn people away from submitting code written by others. I only hope this won't stop the implementation of a nice little feature (or even a fix - someone must have forgotten to put the column in directory listings when placing it in other frames). And, personally, I'd use SIZE_EX...
by paka
2005-01-12 15:53
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

The fact that cologic wrote it first doesn't mean that noone else could write the same (exactly: four) lines of code. Let's have a look at them: ctrlList.InsertColumn(COLUMN_SIZE, CTSTRING(SIZE), LVCFMT_RIGHT, 100, COLUMN_SIZE); +ctrlList.InsertColumn(COLUMN_EXACT_SIZE, CTSTRING&...
by paka
2005-01-12 10:54
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

Yes, the feature is present in BCDC++ 0.668, but not in clean (vanilla) DC++ 0.668. It's four lines of code in directory listing frame source file that add this functionality.
by paka
2005-01-11 17:24
Forum: Feature Discussion (Archived)
Topic: Exact file size column in filelist windows
Replies: 22
Views: 6597

Exact file size column in filelist windows

There's an exact file size column in search window, in download queue, but there is no such column in filelist windows. I find this column very useful when comparing files in my queue, in filelists and on a disk. I've submitted a patch to Bugzilla: http://dcplusplus.sourceforge.net/cgi-bin/bugzilla/...
by paka
2005-01-10 20:33
Forum: Feature Discussion (Archived)
Topic: Files of -1B in size
Replies: 7
Views: 2888

I came across "-1" size with filelists not being downloaded because of no slots available. As I found in QueueManager.h, "-1" is the symbol that DC++ uses for the unknown size of a filelist before it starts to download. And the reason for the size being shown in the transfer window is (as I suppose)...
by paka
2005-01-01 20:49
Forum: Feature Discussion (Archived)
Topic: queue window not refreshed after removing files
Replies: 1
Views: 972

Ullner's patch for this bug has been added to development version 0.669.
by paka
2005-01-01 20:44
Forum: Feature Discussion (Archived)
Topic: invalid directory structure in queue after moving a dir
Replies: 3
Views: 1446

It seems to be exactly the same bug. Sorry for duplicating.

The patch has been added to development version 0.669.
by paka
2004-12-30 19:42
Forum: Feature Discussion (Archived)
Topic: queue window not refreshed after removing files
Replies: 1
Views: 972

queue window not refreshed after removing files

This bug is very easy to reproduce: 1. Open a filelist. 2. Add two directories to the queue (those in the test were about 65 GiBs together, at least a few hundred files). 3. Remove the second directory (probably it doesn't matter which one). 4. The number of total files was decreased only by 1 file ...
by paka
2004-12-30 19:35
Forum: Feature Discussion (Archived)
Topic: Improved sources search
Replies: 29
Views: 9066

GargoyleMT wrote:If it were challenged in a court of law, would that hold up? I suspect it would not.


You're probably right that if JDC++ mod's author really wanted to do some legal abuse, he might win a lawsuit. I read the statement as a good will to put the code he created in the main version of DC++.
by paka
2004-12-30 19:19
Forum: Feature Discussion (Archived)
Topic: invalid directory structure in queue after moving a dir
Replies: 3
Views: 1446

invalid directory structure in queue after moving a dir

I came across such a bug in 0.668: when I rename a directory (pointing at a new, existing directory in system directory tree browsing window) that has subdirectories in my queue, the subdirectories' names are incorporated into filenames, instead of the subdirectories' structure being reconstructed u...
by paka
2004-12-30 15:18
Forum: Feature Discussion (Archived)
Topic: match queue not working after source removed
Replies: 8
Views: 3716

ADC makes it easy to know that two users on different hubs are the same (matching CID), but guessing about that in the NMDC protocol might be what is causing your problem. It may not be helped with the $MyINFO changes (share size may be used to help determine if two users are the same). This is the...
by paka
2004-12-29 19:17
Forum: Feature Discussion (Archived)
Topic: automatic resume of incomplete downloads priority
Replies: 8
Views: 2491

I was asking about the version number because 0.176 (yeah!) had a great anti-incomplete-files feature. Files of the same priority were sorted from the smallest to the biggest one when downloading. It was very effective and you didn't have to change the priority of files. It was changed in 0.177 ("Ch...
by paka
2004-12-29 18:53
Forum: Feature Discussion (Archived)
Topic: match queue not working after source removed
Replies: 8
Views: 3716

Right click the file in download queue thenexpand Re-add source in the manu and click on the user you want to re-add. I'm not sure if I understood you correctly, but I couldn't simply readd the source in the queue because the user changed the source directories in his share. So I did Match queue. B...
by paka
2004-12-29 18:04
Forum: Feature Discussion (Archived)
Topic: Improved sources search
Replies: 29
Views: 9066

No, I don't understand. You've queued 150 GiB of information, but don't have space for all of it. If all of your sources were available now, you'd also run out of space... But they aren't - this is the reality and this is why it is possible. Limited bandwidth also prevents from too speedy disk spac...
by paka
2004-12-29 08:59
Forum: Feature Discussion (Archived)
Topic: Improved sources search
Replies: 29
Views: 9066

However, with multisource, individual files will complete faster, so they spend less time in the temp directory. You're probably right. The question is: how much faster? 2 times? I don't think so. The total upload bandwidth will remain the same (unless ISPs change it) so multi-source can only optim...
by paka
2004-12-28 18:45
Forum: Feature Discussion (Archived)
Topic: automatic resume of incomplete downloads priority
Replies: 8
Views: 2491

Which version of DC++ are you using? Have you tried Settings/Advanced/Use antifragmentation method for downloads?
by paka
2004-12-28 18:32
Forum: Feature Discussion (Archived)
Topic: match queue not working after source removed
Replies: 8
Views: 3716

match queue not working after source removed

After I get "File not available" from a user or after I remove him as a source from the queue, match queue doesn't put him as a source (without restarting DC++). I came across it in 0.666 (after "File not available"). The user had a TTH filelist. And it also occurs in 0.668. This time I did Match qu...
by paka
2004-12-28 17:49
Forum: Feature Discussion (Archived)
Topic: delete incomplete filelists
Replies: 10
Views: 3283

delete incomplete filelists

I have the feature "Don't delete file lists when exiting" switched on. When I start to download a filelist and delete it from the queue before it finishes, the incomplete filelist remains on the disk. I think it should be deleted, just like other incomplete files that are removed from the queue. I'm...
by paka
2004-12-28 17:41
Forum: Feature Discussion (Archived)
Topic: automatic resume of incomplete downloads priority
Replies: 8
Views: 2491

You can right-click the file in the download queue, choose Set priority and change it to a higher level, for example: High. Then - if a transfer from the desired user is already running - stop it and when DC++ reconnects, the file with a higher priority will start to download.
by paka
2004-12-28 17:00
Forum: Feature Discussion (Archived)
Topic: Improved sources search
Replies: 29
Views: 9066

1) more space (a lot!) for incomplete files is needed (unless you store the segments in separate files), It requires no more space than the completed file + some bitmap that tells which chunks have been completed (which would probably be roughly the size of the TTHL (24k). That's exactly what I mea...
by paka
2004-12-27 20:54
Forum: Feature Discussion (Archived)
Topic: Improved sources search
Replies: 29
Views: 9066

Multi-source downloading has 2 major drawbacks: 1) more space (a lot!) for incomplete files is needed (unless you store the segments in separate files), 2) a higher total number of slots will be needed for the same bandwidth that the users have which is pointless and potentially increases the number...